[wp-trac] [WordPress Trac] #13071: Update bubble appears only at the second load

WordPress Trac noreply at wordpress.org
Sun Oct 16 19:54:23 UTC 2016


#13071: Update bubble appears only at the second load
-------------------------------------------------+-------------------------
 Reporter:  ocean90                              |       Owner:  swissspidy
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.7
Component:  Upgrade/Install                      |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  shiny-updates has-patch needs-       |     Focuses:
  testing                                        |  administration
-------------------------------------------------+-------------------------
Changes (by ocean90):

 * owner:  ocean90 => swissspidy


Comment:

 Thanks @swissspidy. Found a few issues with [attachment:13071.2.diff]. I
 fixed them in [attachment:13071.3.diff]:

 * The counter in `.subsubsub` didn't update for plugins because
 `settings.totals.counts.themes` was used. Changed to `itemCount`.
 * Yoda conditions should only be used for
 [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/php/#yoda-conditions ==, !=, ===, and !==].
 * Added a missing semicolon and DocBlock.
 * `_wpUpdatesItemCounts` wasn't defined on `wp-admin/themes.php`.
 * `_wpUpdatesItemCounts` wasn't always defined on `wp-admin/update-
 core.php`. Bulk theme/plugin upgrades have their own output.
 * The update script is printed in the header since [27280]. I couldn't
 find a reason for that so I changed the group. `postMessage` is still
 working for me. Needs some testing.
 * Changing the group allows us to use `wp_localize_script()` in all
 places.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/13071#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list