[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

WordPress Trac noreply at wordpress.org
Fri Oct 14 18:55:57 UTC 2016


#38172: Enable Video Headers in Custom Headers
----------------------------+--------------------
 Reporter:  davidakennedy   |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  4.7
Component:  Themes          |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+--------------------

Comment (by mikeschroder):

 Replying to [comment:34 aaroncampbell]:
 > After reviewing the patch, my first thoughts were exactly the same as
 @mikeschroder. However, after reading through all the comments on here (I
 was largely convinced by @pento's data), I think the simple plain `video`
 tag is fine with the image fallback.

 I prefer MEjs here for compatibility, but this is less of a sticking
 point/blocker.

 Either way, I think that the `video` tag, if that's the route chosen,
 should be generated by common code with `wp_video_shortcode()` -- even if
 it's only the `video` tag generation parts abstracted out into a new
 function.


 Another question:
 Is there anything being done to make sure that mobile clients don’t
 download large files here?

 The media team has been doing work to reduce page download sizes across
 the board. I’m concerned that we might be set to gradually increase total
 page size across the web if we encourage the use of video headers/make one
 a default in Twenty Seventeen.

 This is something that I would like to see addressed before a merge of
 this feature.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list