[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-----------------------------+--------------------
 Reporter:  davidakennedy    |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  4.7
Component:  Themes           |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+--------------------
Changes (by mikeschroder):

 * type:  task (blessed) => feature request


Comment:

 @davidakennedy asked me to take a look at this.

 I'll note that I'm not a big fan of video headers, and find them very
 distracting (like Sliders), rather than helpful, but it looks like I'm in
 the minority opinion there.

 On the code/method:
 I defer to @obenland on his notes RE: the theme API, as it's not my area
 of expertise.

 In general, the code seems fairly straight-forward and easy to follow.

 I agree with a few others here that this really should use existing core
 infrastructure to generate the video markup (including MEjs), and
 abstracting the parts needed if current API does too much for this
 purpose.

 It's been difficult/frustrating to maintain the other media related theme
 bits that use separate interfaces/generation and don't use the common
 media infrastructure (see current custom headers, and anything that crops
 for theme support, for example).

 I'd hate to see this become another example of that. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform