[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
----------------------------+--------------------
 Reporter:  davidakennedy   |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  4.7
Component:  Themes          |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+--------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => has-patch


Comment:

 [attachment:38172.3.diff] adds the customizer UI, updated header images as
 needed. The header image is now used as a fallback if the browser can't
 play the video. The patch also adds support for video headers to Twenty
 Fourteen, which will facilitate testing (and that theme's use of headers
 lends itself to video).

 Unfortunately it doesn't look like we can easily add selective refresh to
 header images in a backwards-compatible way. The new video functions will
 selectively refresh, though. This is important for visibile edit icons
 (#27403).

 The implementation in Twenty Fourteen is a bit complex because there are a
 few issues and I wanted to minimize the markup changes there. The sticky
 menu code there gets a bit messy if the fallback image is a different size
 than the video.

 New themes should use `the_custom_header()` to handle displaying both the
 video and the image as needed, with selective refresh for video. A lot of
 themes are adding header images as background images currently - when
 adding support for video and in new themes, equivalent styling should be
 created as needed based on the markup that `the_custom_header()` outputs.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform