[wp-trac] [WordPress Trac] #23870: Filter Glyph for Comment Required Fields

WordPress Trac noreply at wordpress.org
Mon Oct 10 17:34:36 UTC 2016


#23870: Filter Glyph for Comment Required Fields
-------------------------+-----------------------
 Reporter:  cais         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.7
Component:  Comments     |     Version:  3.5
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  template
-------------------------+-----------------------
Changes (by SergeyBiryukov):

 * keywords:  good-first-bug has-patch => has-patch
 * component:  I18N => Comments
 * milestone:  Future Release => 4.7


Comment:

 Attached a version with the argument, just in case, so we could choose
 from both options :)

 I'm ambivalent at the moment. Most themes only have one comment form, so
 the argument seems cleaner.

 On the other hand, if a theme has more than one form, and/or utilizes
 other `comment_form_*` filters, the filter would probably make more sense.

 Moving to the milestone to make a decision. I18N is not the main part of
 the ticket though, so moving back to the Comments component.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23870#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list