[wp-trac] [WordPress Trac] #23477: r21789 creates a breaking change in behavior for get_submit_button

WordPress Trac noreply at wordpress.org
Sun Oct 9 20:06:58 UTC 2016


#23477: r21789 creates a breaking change in behavior for get_submit_button
-----------------------------------------+------------------------------
 Reporter:  vhauri                       |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Administration               |     Version:  3.5
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch ui-feedback close  |     Focuses:  ui
-----------------------------------------+------------------------------
Changes (by afercia):

 * keywords:  has-patch ui-feedback dev-feedback => has-patch ui-feedback
     close
 * severity:  major => normal


Comment:

 I'd be in favor of closing this ticket. The CSS class `button-secondary`
 should simply not be used, because buttons using it:
 - they would be not responsive
 - the focus style is wrong
 - the `button` base class looks exactly the same (and responsiveness and
 focus are OK)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23477#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list