[wp-trac] [WordPress Trac] #23870: Filter Glyph for Comment Required Fields

WordPress Trac noreply at wordpress.org
Fri Oct 7 20:44:00 UTC 2016


#23870: Filter Glyph for Comment Required Fields
----------------------------------------+-----------------------------
 Reporter:  cais                        |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  I18N                        |     Version:  3.5
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  template
----------------------------------------+-----------------------------

Comment (by cais):

 @rachelbaker, @johnbillion - I don't think making the required "mark" part
 of the translation string would be the same as making it filter-able
 although an interesting idea to still take into consideration.

 If the symbol is part of the translation string it could only be changed
 by over-writing the default comment strings as seen in the examples above
 which makes the idea of directly adding a filterable variable as moot and
 puts the idea of changing the symbol back on the theme or plugin developer
 that chooses to do so (while still allowing the translator to essentially
 overwrite it all the same?!)

 The premise I was putting forward was to add more of a design element to
 the symbol versus just making it different (such as via a translation
 string). I do not have any specific use case where it has been changed and
 even though I have implemented a filterable method into one of my themes
 to allow the symbol to be changed I am not aware of any case where it
 actually has been changed, even by myself. The theme's implementation
 still uses the default asterisk.

 I imagine the two ideas could still be put together and sorted out with a
 bit more refactoring but I may also have been a bit over-zealous with
 making "all the things" filter-able in the theme that gave me the impetus
 to suggest this enhancement.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23870#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list