[wp-trac] [WordPress Trac] #38071: Add status links to network/sites.php

[WordPress Trac]

#38071: Add status links to network/sites.php
-------------------------------------------------+-------------------------
 Reporter:  johnjamesjacoby                      |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.7
Component:  Networks and Sites                   |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  multisite
  unit-tests                                     |
-------------------------------------------------+-------------------------

Comment (by rheinardkorf):

 Definitely needs unit tests.

 The following is not a reliable method.

 {{{
 protected function is_base_request() {
                 $vars = $_GET;
                 unset( $vars['paged'] );

                 if ( empty( $vars ) ) {
                         return true;
                 }

                 return 1 === count( $vars ) && ! empty( $vars['mode'] );
         }
 }}}

 Plugins may add additional functionality via URI, so simply unsetting
 'paged' or checking for only 'mode' is does not give the intended result.
 It is better to check for the presence/absence of 'site_status'.

 The rest is looking pretty good.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38071#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform