[wp-trac] [WordPress Trac] #36356: Function signature of wp_parse_url() does not match parse_url()

WordPress Trac noreply at wordpress.org
Tue Oct 4 20:01:54 UTC 2016


#36356: Function signature of wp_parse_url() does not match parse_url()
--------------------------------------+----------------------------
 Reporter:  johnbillion               |       Owner:  peterwilsoncc
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.7
Component:  HTTP API                  |     Version:  4.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+----------------------------

Comment (by peterwilsoncc):

 [attachment:36356.3.2.diff]  for history while I wait for the [https
 ://travis-ci.org/peterwilsoncc/WordPress/builds/165053167 full test suite
 to run].

 @jrf Thanks for looking over that, I've added the check before unsetting.

 HHVM isn't failing on the Google URLs so it looks like the placeholders
 are covering that.

 I'll leave the ampersand as is, php, chrome network tools and firefox
 inspector all show it as part of the path. So it's at least consistent.
 I've removed these tests.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36356#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list