[wp-trac] [WordPress Trac] #36202: Menus screen: fix persistence of toggles for displayed nav menu item properties

[WordPress Trac]

#36202: Menus screen: fix persistence of toggles for displayed nav menu item
properties
--------------------------+-----------------------------
 Reporter:  afercia       |       Owner:  ryankienstra
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  Menus         |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, javascript
--------------------------+-----------------------------

Comment (by westonruter):

 @ryankienstra I found one more edge case related to our PR:
 https://github.com/xwp/wordpress-develop/pull/159

 See [attachment:"screen options.png"]. The screen options on the edit
 posts screen, in addition to these checkboxes, also has a form for
 inputting pagination and the view mode. This form has an Apply button. If
 you are quick with your checkbox selections and then quickly tab down to
 hit Apply, the `hidden-columns` Ajax request will not have a change to
 send, and once the form has been submitted and the page reloads, the
 checkboxes will remain as they were before.

 The only thing I can think of to fix this would be to perhaps add a
 `submit` event handler for the `adv-settings` form which can listen to
 whether or not there is a pending `hidden-columns` Ajax request. If so,
 then the submit should be prevented and instead deferred until the Ajax
 request is `done`. Not super pretty. There may be a better way to go about
 it, like maybe including the `hidden-columns` in the `adv-settings`
 request.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36202#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform