[wp-trac] [WordPress Trac] #36901: Removing wp_die() from wp_allow_comment()

[WordPress Trac]

#36901: Removing wp_die() from wp_allow_comment()
-------------------------------------------------+-------------------------
 Reporter:  websupporter                         |       Owner:
     Type:  enhancement                          |  rachelbaker
 Priority:  normal                               |      Status:  assigned
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.6
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by websupporter):

 This patch modifies 36901.2.diff.

 Two problems I had with 36901.2:

 1. `wp_is_comment_flood` needed to filter the boolean `$is_flood` but
 actually filtered the authors IP. (L668)

 2. It still executed `check_commend_flood_db()` in `wp_allow_comment()`
 although its hooked in. (L676)

 Just wanted to add this quickly, so we have a working patch.

 I see how this would be BC now :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36901#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform