[wp-trac] [WordPress Trac] #38948: More difficult to create submenus in customizer

WordPress Trac noreply at wordpress.org
Tue Nov 29 14:24:26 UTC 2016


#38948: More difficult to create submenus in customizer
-----------------------------+-------------------------
 Reporter:  adamsilverstein  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.7
Component:  Customize        |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  javascript
-----------------------------+-------------------------

Comment (by delawski):

 @adamsilverstein - You're totally right! My mistake was to use
 `expandedSection` that is fired before the animation is started instead of
 just `args.completeCallback` function which is called right after the
 transition is completed (https://github.com/xwp/wordpress-
 develop/blob/master/src/wp-admin/js/customize-controls.js#L1006-L1021 -
 `_animateChangeExpanded` takes a callback as an argument, that is called
 after the transition is complete).

 So, just as you suggested, instead of using delay function, the
 `completeCallback` function can be extended, and the exact end of the
 transition can be used. I've attached an
 [https://core.trac.wordpress.org/attachment/ticket/38948/38948_2.diff
 updated patch] that is following that path.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38948#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list