[wp-trac] [WordPress Trac] #38946: WP_Upgrader: Protection against deleting files in destination directory

[WordPress Trac]

#38946: WP_Upgrader: Protection against deleting files in destination directory
-----------------------------+------------------------------
 Reporter:  shivapoudel      |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------

Comment (by shivapoudel):

 Replying to [comment:1 dd32]:

 @dd32 It wouldn't be possible to simply guess the basename of package,
 strip `.zip` extension and set that match as subdirectory for
 `destination` arg. This is because it may result subdirectory like
 `uploaded-demo-pack-{1|2|3|..}` and inside zip folder the directory name
 is predefined and look like `uploaded-demo-pack`.

 This above patch tries to implement `protect_destination` arg and have
 defaults set to false :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38946#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform