[wp-trac] [WordPress Trac] #38918: delete_plugins() needs a proper singular and plural form for its error message

[WordPress Trac]

#38918: delete_plugins() needs a proper singular and plural form for its error
message
--------------------------------------+------------------------------
 Reporter:  johnbillion               |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Plugins                   |     Version:  2.6
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------------
Changes (by eddhurst):

 * keywords:  good-first-bug has-patch 2nd-opinion => good-first-bug has-
               patch


Comment:

 Tested a couple of older versions to check against what they were doing
 and in the eventuality that multiple plugins failed to delete, only the
 last message would show anyway (deleted 3 plugins, but was shown the
 following error):

 `Plugin could not be deleted due to an error: Could not fully remove the
 plugin: rest-api/plugin.php.`

 Given that all these errors have been brought in-line anyway now, each
 error will show next to the relevant plugin that's failed (if multiple),
 so a singular phrase seems fine.

 I've added an extra patch to force errors on successfully removing a
 plugin, just to make testing the output a little easier - the initial
 patch is the correct one to apply going forward.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38918#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform