[wp-trac] [WordPress Trac] #38905: REST API: Bring consistency to the `rest_insert_*` actions

WordPress Trac noreply at wordpress.org
Wed Nov 23 15:32:27 UTC 2016


#38905: REST API: Bring consistency to the `rest_insert_*` actions
------------------------------------+--------------------------
 Reporter:  rachelbaker             |       Owner:  rachelbaker
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:  4.7
Component:  REST API                |     Version:  trunk
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+--------------------------
Changes (by rachelbaker):

 * owner:   => rachelbaker
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39348"]:
 {{{
 #!CommitTicketReference repository="" revision="39348"
 REST API: Always fire the `rest_insert_*` actions after the related object
 is updated or inserted.

 Brings consistency to the `rest_insert_*` actions. Also includes some
 shuffling and clean-up as well including:
 - Ensure we are passing the most current `$post` and `$user` objects to
 the `update_additional_fields_for_object()` callbacks.
 - Changes the function signature of `handle_status_param()` in the
 Comments controller to accept just the comment_id as the 2nd parameter,
 instead of a full WP_Comment object. Only the comment_id is needed in the
 method, this avoids having to include another `get_comment()` call.
 - Renames a variable in the `create_item()` method of the Posts controller
 from `$post` -> `$prepared_post` to be more explicit.
 - Minor fixes/clarifications to the rest_insert_* hook docs

 Props rachelbaker, joehoyle
 Fixes #38905.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38905#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list