[wp-trac] [WordPress Trac] #38890: Customize: Selective refresh for nav menus can cause infinite reloads when it contains invalid menu items

[WordPress Trac]

#38890: Customize: Selective refresh for nav menus can cause infinite reloads when
it contains invalid menu items
--------------------------+--------------------------
 Reporter:  westonruter   |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39333"]:
 {{{
 #!CommitTicketReference repository="" revision="39333"
 Customize: Prevent selective refresh from causing infinite fallback
 refreshes when nav menu contains invalid items.

 Invalid nav menu items are exported as settings in the customize controls
 since it `is_admin()`, but any such `nav_menu_item` settings are excluded
 from the preview since it's the frontend. Selective refresh for nav menus
 needs to ignore the syncing of any such `nav_menu_item` settings that are
 `_invalid` since they are never rendered, and when a nav menu only
 contains invalid items, an infinite fallback refresh can ensue.

 Fixes #38890.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38890#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform