[wp-trac] [WordPress Trac] #38849: Shortcode wpview's toolbar appears while no view is selected

WordPress Trac noreply at wordpress.org
Sat Nov 19 03:16:14 UTC 2016


#38849: Shortcode wpview's toolbar appears while no view is selected
---------------------------------------+-----------------------------
 Reporter:  bduclos                    |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Future Release
Component:  TinyMCE                    |     Version:  4.6.1
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  javascript
---------------------------------------+-----------------------------
Changes (by gitlost):

 * keywords:  has-screenshots needs-patch => has-screenshots has-patch


Comment:

 The patch checks that the view is selected before setting the toolbar on
 the `wptoolbar` event in "tinymce/plugins/wpview/plugin.js".

 There's also a change to the `nodechange` action in
 "tinymce/plugins/wordpress/plugin.js" just after it fires the `wptoolbar`
 event, to make sure the toolbar is repositioned and shown always, in case
 a selected view is scrolled out of view and then a different (visible!)
 view selected, which could have resulted in the toolbar not displaying on
 the newly selected view.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38849#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list