[wp-trac] [WordPress Trac] #38615: Round out and refine starter content

[WordPress Trac]

#38615: Round out and refine starter content
----------------------------+------------------
 Reporter:  helen           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  high            |   Milestone:  4.7
Component:  Themes          |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------

Comment (by westonruter):

 [attachment:38615.8.diff] fixes the problem with array to string
 conversion notice. It was a [https://github.com/xwp/wordpress-
 develop/pull/201/commits/0664f7e51c781722af142b2573cb584ec14927a9#diff-
 4fb8a477f559bdfad2c1e6db6d1c8b06L1080 trivial oversight] (of mine).

 Also [https://github.com/xwp/wordpress-
 develop/pull/201/commits/6940730e62a48555c8305d75e5aa089e88cff84c fixed an
 issue] an “undefined index: sizes” PHP notice. When a header image is not
 sourced from an attachment, then there is no `sizes` item in the array
 passed to the `get_header_image_tag` filter. Maybe the `sizes` should be
 defined in the array defaults to prevent that from happening unexpectedly.
 (But that's been the case since 4.4.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38615#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform