[wp-trac] [WordPress Trac] #26855: get_blogaddress_by_id used in wp-activate.php limits functionality in MU Domain Mapped Sites

[WordPress Trac]

#26855: get_blogaddress_by_id used in wp-activate.php limits functionality in MU
Domain Mapped Sites
-------------------------------------+-------------------------
 Reporter:  boboudreau               |       Owner:  jeremyfelt
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.7
Component:  Networks and Sites       |     Version:  3.0
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:  multisite
-------------------------------------+-------------------------
Changes (by jeremyfelt):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Hi @warrenreeves, thanks for following up with this info.

 I ''think'' everything is still okay here. The described scenario occurred
 before the switch to `get_home_url()` in this ticket.

 I just went through 3 flows involving `wp-activate.php`, and here's what I
 get:

 1. If I signup at `site/wp-signup.php` for a site and a username, and then
 click on the link in the activation email, `wpmu_activate_signup()`
 returns a `$result` containing the `blog_id` key as expected. In this
 case, we show a link to "View your site" with the proper URL.
 2. If I signup at `site/wp-signup.php` for a username only, and then click
 on the link in the activation email, `wpmu_activate_signup()` returns a
 `$result` that does not contain the `blog_id` key, but instead contains
 only user information. There is no `add_to_blog` meta key in this scenario
 and we show a link to login as the user.
 3. If I add a new user to a site in `user-new.php`, and the user clicks on
 the link in the activation email, `wpmu_activate_signup()` returns a
 `$result` that does not contain the `blog_id` key, and again contains only
 the user information. In this case there is a `add_to_blog` meta key, but
 we still only show a link to login as the user.

 I do think it's possible that we could add a future enhancement that looks
 for the `add_to_blog` meta key and shows a home url to the user based on
 that. For now, everything appears to work as expected.

 I'm going to close this out as fixed again, as we're nearing RC for 4.7.
 Please feel free to comment and reopen if I'm misreading the issue here. A
 new ticket for the enhancement would be good for discussion as well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26855#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform