[wp-trac] [WordPress Trac] #38776: Twenty Seventeen: Remove color scheme support from edit shortcuts

[WordPress Trac]

#38776: Twenty Seventeen: Remove color scheme support from edit shortcuts
--------------------------+-------------------------
 Reporter:  helen         |       Owner:  sirbrillig
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui
--------------------------+-------------------------
Changes (by celloexpressions):

 * keywords:  has-patch => needs-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Twenty Seventeen still resets the text-shadow when there's a custom color
 scheme - that needs to be removed (see
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyseventeen/style.css#L2994). There's another style
 that's probably not needed, here:
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyseventeen/style.css#L2984.

 Since the icons are persistently on with no way to turn them off while
 customizing, and we're discouraging themes from recoloring them, I'd
 definitely prefer using a neutral color. That follows the UI patterns of
 the customize pane (which uses the blue accent color only very minimally)
 and will also mitigate clashes with theme colors. Themes (or custom
 colors) using blue prominently will tend to clash pretty badly with the
 fairly uncommon hue of WP blue that the icons have here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38776#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform