[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions

[WordPress Trac]

#38738: Remove front page restrictions from new custom header functions
--------------------------------------+--------------------
 Reporter:  peterwilsoncc             |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  4.7
Component:  Themes                    |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------
Changes (by joemcgill):

 * keywords:  has-patch has-unit-tests 2nd-opinion => has-patch has-unit-
               tests


Comment:

 [attachment:38738.7.diff] looks good to me, and I'm starting to come
 around to the idea of `is_header_video_active` as the name of the
 conditional function. The comment on the `@param` in the docs for the
 filter in that function should be split into separate lines, but that can
 be handled in the commit.

 The last thing to note is that `is_header_video_active()` (or whatever we
 end up with) should be used as the `active_callback` in the customizer
 (see: #38778). If this lands first, we can update the patch on that
 ticket, but if that ticket lands first, we'll want to make the update
 here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform