[wp-trac] [WordPress Trac] #37997: Increase in function calls to get_locale() because of _load_textdomain_just_in_time()

[WordPress Trac]

#37997: Increase in function calls to get_locale() because of
_load_textdomain_just_in_time()
-------------------------------------------------+-------------------------
 Reporter:  sharkomatic                          |       Owner:  ocean90
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.7
Component:  I18N                                 |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing has-patch needs-unit-  |     Focuses:
  tests                                          |  performance
-------------------------------------------------+-------------------------

Comment (by jrf):

 @ocean90

 > I think we just need to find some better names for the functions. :)

 Agreed, I wasn't feeling very creative when I coded it ;-) Suggestions
 welcome.

 > We could probably merge _get_path_to_glotpress_translation() into
 _get_path_to_translation() but I get the single responsibility idea.

 Having them as two separate functions will also make it a lot easier to
 unit test this ;-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37997#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform