[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design

[WordPress Trac]

#38697: Twenty Seventeen: Video header pause button design
------------------------------------+------------------------
 Reporter:  melchoyce               |       Owner:  joemcgill
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Bundled Theme           |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------

Comment (by laurelfulford):

 Thanks @bradyvercher and @joemcgill!

 I completely missed that there was a filter available. That looks like the
 best approach to me, since we do need to inject the SVGs into the markup -
 we need to change the colour of the icon from white to black via CSS for
 the dark colour scheme.

 Given this, I also agree that the `span` in the button markup isn't needed
 - if a theme requires markup to style the button in a specific way, it can
 added with the filter.

 Twenty Seventeen isn't otherwise bundled with an icon font, and uses
 inline SVGs for other icons. For consistency I'd like to stick with that,
 but both the icon fonts and CSS icons are solid alternatives to style this
 button.

 I'll update the patch now. Thanks again!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform