[wp-trac] [WordPress Trac] #38391: Twenty Seventeen: Background colour for header

[WordPress Trac]

#38391: Twenty Seventeen: Background colour for header
--------------------------------------+----------------------------
 Reporter:  laurelfulford             |       Owner:  davidakennedy
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.7
Component:  Bundled Theme             |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+----------------------------

Comment (by davidakennedy):

 Replying to [comment:14 celloexpressions]:

 That's good feedback. Thanks!

 > Can we remove the header text color option for Twenty Seventeen?

 I think it's better to leave it because without it, a user can't modify it
 based on the type of header image or video they upload.

 >  If we want to keep it, it should only apply or be visible as an option
 when there's an image; otherwise it falls outside the intended purpose of
 the option, causes confusion for users, and diverges from the carefully-
 designed custom color options/patterns in use for the rest of the theme.

 That's what was experimented a bit with on this ticket. I don't think
 there's harm in having it be present all the time to give user's some
 flexibility.

 > The color scheme controls are always shown, at least the last time I
 checked. Not sure how that's related here?

 They are – right.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38391#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform