[wp-trac] [WordPress Trac] #38651: Customizer edit icons may be partially off-screen in Device Preview mode

WordPress Trac noreply at wordpress.org
Thu Nov 10 22:18:04 UTC 2016


#38651: Customizer edit icons may be partially off-screen in Device Preview mode
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  sirbrillig
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.7
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch reporter-  |     Focuses:
  feedback 2nd-opinion                           |
-------------------------------------------------+-------------------------

Comment (by sirbrillig):

 @MarcosAlexandre Thank you for your efforts here! I think it does look
 better but I'm worried about adding too many element-specific rules in the
 core CSS (`#site-navigation`, `.footer-widget-1`, etc.). (Also I can't
 apply that patch to master directly so it's difficult to test.)

 > it seems that there is not a perfect solution.

 @sstoqnov Agreed. I like your solution number 2. The patch works well in
 all the places I tested.

 I think we should probably remove the left-margin guard anyway, due to the
 issues described in my previous comment, so perhaps we can combine both
 approaches? I will attached one now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38651#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list