[wp-trac] [WordPress Trac] #38651: Customizer edit icons may be partially off-screen in Device Preview mode

WordPress Trac noreply at wordpress.org
Tue Nov 8 21:56:23 UTC 2016


#38651: Customizer edit icons may be partially off-screen in Device Preview mode
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.7
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch reporter-  |     Focuses:
  feedback 2nd-opinion                           |
-------------------------------------------------+-------------------------

Comment (by sirbrillig):

 I think that this issue could benefit from a more detailed description of
 what we want it to look like.

 Mostly it seems that we want icons to "not be off the page and not
 overlapping things", but that's tricky because it begs the question:
 "where do the icons go, then"?

 In Slack @helen made this proposed definition, which may be more workable:

 > Well, I think it’s confusing when it overlaps text that otherwise has
 enough or at least some amount of unused whitespace next to it that the
 shortcut could be in.

 So maybe we could examine the icon position and the element position in
 the JavaScript and make some position decisions based on that information.
 I'll play around and see if anything works.

 Please continue brainstorming and experimenting, though. This is a good
 conversation!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38651#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list