[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility

WordPress Trac noreply at wordpress.org
Sat Nov 5 01:09:18 UTC 2016


#38678: Video Headers: Improve Basic Accessibility
---------------------------+----------------------------
 Reporter:  davidakennedy  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Themes         |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  accessibility
---------------------------+----------------------------

Comment (by bradyvercher):

 This looks pretty straightforward to me. Like you mentioned, themes can
 style the button as necessary. A couple of thoughts:

 * The button probably needs a class to indicate the state of the video so
 themes can swap out play and pause icons when necessary.
 * The strings can be added to the settings array in
 `get_header_video_settings()` so they can be translated.
 * Is it worth updating the rest of the code to use `setAttribute()` to
 make it consistent?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list