[wp-trac] [WordPress Trac] #38645: Improve roles reinit when switching between sites

[WordPress Trac]

#38645: Improve roles reinit when switching between sites
-------------------------------------------+------------------------------
 Reporter:  johnjamesjacoby                |       Owner:
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  Awaiting Review
Component:  Role/Capability                |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch needs-testing early  |     Focuses:  multisite
-------------------------------------------+------------------------------

Comment (by flixos90):

 Replying to [comment:7 johnjamesjacoby]:
 > Unless we go back and rename `WP_User::for_ blog()`, it's hard to
 endorse anything else.

 I agree with @knutsp that we should use `for_site()`. We shouldn't be
 locked in by the old naming conventions, so everything new should be
 properly named. Eventually we will be able to rename many of the old
 things over (long) time, but introducing new functionality in that way
 seems wrong to me.

 Another issue that just came to mind is whether that function should exist
 in that form at all: Let's imagine `WP_Roles` is extended by a future
 `WP_Network_Roles`, what would a `for_site()` / `for_blog()` method do? It
 might be a better idea to find a more generic name.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38645#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform