[wp-trac] [WordPress Trac] #38557: Format for registering a default header image is ambiguous

WordPress Trac noreply at wordpress.org
Thu Nov 3 19:01:18 UTC 2016


#38557: Format for registering a default header image is ambiguous
-----------------------------------+------------------------------
 Reporter:  bradyvercher           |       Owner:  pento
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Themes                 |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------

Comment (by joemcgill):

 In [changeset:"39123"]:
 {{{
 #!CommitTicketReference repository="" revision="39123"
 Themes: Improve support for placeholders in default headers.

 When themes register default headers, they can use sprintf style
 placeholder
 strings in place of the template directory URI, which WordPress transforms
 in several places by running the value of
 `get_theme_support( 'custom-header', 'default-image' )` through
 `sprintf()`.

 This fixes a few places where WordPress skipped the `sprintf()` step and
 referenced the `get_theme_support()` value directly.

 Props bradyvercher for initial patch.
 See #38557.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38557#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list