[wp-trac] [WordPress Trac] #38476: Twenty Seventeen: Focused controls may be hidden by the top menu.

WordPress Trac noreply at wordpress.org
Tue Nov 1 23:37:42 UTC 2016


#38476: Twenty Seventeen: Focused controls may be hidden by the top menu.
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  defect (bug)                         |  davidakennedy
 Priority:  normal                               |      Status:  assigned
Component:  Bundled Theme                        |   Milestone:  4.7
 Severity:  normal                               |     Version:
 Keywords:  has-screenshots has-patch needs-     |  Resolution:
  testing dev-feedback                           |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by davidakennedy):

 [attachment:38476.2.patch] builds on the work of @Fencer04. It:

 * Makes sure the `scrollTo` plugin loads on every page since it can be
 called at any time now.
 * Moves the work into the `$( document ).ready( function()` part of the
 file so we know jQuery is loaded, etc.
 * Targets links only in main body of page so selector is more performant.
 * Also, only calls function if the nav is sticky.

 Nice way to kick things off @Fencer04! I still feel like this needs more
 work. It doesn't work on all cases for me. I'll try to make a screencast
 tomorrow. But encourage people to test this patch and iterate on it.
 @afercia Feel free to test too!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38476#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list