[wp-trac] [WordPress Trac] #36587: PHPUnit Tests fail with PHP7 and Imagick 3.4.x

WordPress Trac noreply at wordpress.org
Sun May 29 08:07:08 UTC 2016


#36587: PHPUnit Tests fail with PHP7 and Imagick 3.4.x
--------------------------------+------------------
 Reporter:  alpipego            |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  high                |   Milestone:  4.6
Component:  Media               |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  upstream has-patch  |     Focuses:
--------------------------------+------------------

Comment (by dd32):

 Replying to [comment:22 mikeschroder]:
 > What are the ways in which users are most likely to experience this
 problem in the real world? (want to be sure I'm not missing cases here)

 One way of looking at it; It upgrades any PHP Warnings thrown by any code
 to effectively PHP Fatals. That would be triggered (as in this case) by
 either malformed exif data (or other plugin issues) where warnings were
 expected and were explicitly silenced by `@`.

 > I'd hope this also, *if* we give hosts enough runway/notice to do it. In
 reality, some, but not all hosts will be upgraded, so I'd like to look at
 this from the user perspective.

 I firmly believe the user experience of not having a broken response is
 the primary objective. We shouldn't have to tell hosts to fix broken stuff
 or that a recently released extension on a brand new PHP branch is faulty
 - that's their responsibility to keep up to speed on. Our responsibility
 is to offer a seamless experience for our users, and degrade gracefully
 where appropriate.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36587#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list