[wp-trac] [WordPress Trac] #36415: Unit tests for functions.php's get_weekstartend method

WordPress Trac noreply at wordpress.org
Thu May 26 15:46:26 UTC 2016


#36415: Unit tests for functions.php's get_weekstartend method
-------------------------------------------------+-------------------------
 Reporter:  tloureiro                            |       Owner:
     Type:  enhancement                          |  boonebgorges
 Priority:  normal                               |      Status:  assigned
Component:  Date/Time                            |   Milestone:  4.6
 Severity:  normal                               |     Version:  0.71
 Keywords:  has-patch has-unit-tests dev-        |  Resolution:
  feedback                                       |     Focuses:
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => assigned


Comment:

 @pbearne Thanks for the patch!

 The `strtotime()` tests don't really test `get_weekstartend()`, they test
 `strtotime()` and `date()`. I don't think we need to do that.

 I'm going to add one or two additional tests, and change some wording.
 Otherwise looks good. Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36415#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list