[wp-trac] [WordPress Trac] #36916: Refactor EditAttachments frame to work outside Media Library admin page

WordPress Trac noreply at wordpress.org
Mon May 23 13:43:21 UTC 2016


#36916: Refactor EditAttachments frame to work outside Media Library admin page
---------------------------------+-----------------------------------------
 Reporter:  Funkatronic          |       Owner:
     Type:  enhancement          |      Status:  new
 Priority:  normal               |   Milestone:  Awaiting Review
Component:  Media                |     Version:  4.5.2
 Severity:  normal               |  Resolution:
 Keywords:  has-patch needs-     |     Focuses:  javascript, administration
  testing                        |
---------------------------------+-----------------------------------------

Comment (by adamsilverstein):

 Hey @Funkatronic, thanks for the suggestion and the patch!

 Looking at the patch briefly it seems reasonable, can you provide a code
 snippet showing how you would use the edit dialog demonstrating how the
 patch helps you? My main concern with this change is that we might
 unexpectedly break the routing behavior (for example re/loading a url in
 the edit mode). I don't think we have good unit tests to verify this, so
 we need to test carefully.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36916#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list