[wp-trac] [WordPress Trac] #15800: Adding tabs to the "Edit Site"-pages in Network Admin

WordPress Trac noreply at wordpress.org
Fri May 20 09:45:36 UTC 2016


#15800: Adding tabs to the "Edit Site"-pages in Network Admin
-------------------------+-------------------------------------------------
 Reporter:               |       Owner:  jeremyfelt
  PuffyThePirateBoy      |      Status:  reopened
     Type:  enhancement  |   Milestone:  4.6
 Priority:  normal       |     Version:  3.1
Component:  Networks     |  Resolution:
  and Sites              |     Focuses:  accessibility, administration,
 Severity:  minor        |  multisite
 Keywords:  needs-patch  |
-------------------------+-------------------------------------------------
Changes (by ocean90):

 * keywords:  has-patch => needs-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Some feedback about [37466]:

 * Comments, DocBlock descriptions  and summaries, @param descriptions
 should all end with a period.
 * We haven't used the `@link` tag to link to tickets yet and I don't think
 it's necessary.
 * The docs for the first param of `network_edit_site_nav_links` should be
 documented in hash notation style. It's also missing a variable name like
 `$links`. And it should be documented that the URL is relative to
 `network_admin_url()`.
 * I don't see a need for the output buffer in `network_edit_site_nav()`.
 * `$classes` is a hardcoded list, so `$esc_classes` seems superfluous.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15800#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list