[wp-trac] [WordPress Trac] #34893: Improve Customizer setting validation model

WordPress Trac noreply at wordpress.org
Mon May 16 19:31:47 UTC 2016


#34893: Improve Customizer setting validation model
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:
     Type:  enhancement                          |  westonruter
 Priority:  high                                 |      Status:  accepted
Component:  Customize                            |   Milestone:  4.6
 Severity:  normal                               |     Version:  3.4
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests has-screenshots                          |     Focuses:  javascript
-------------------------------------------------+-------------------------

Comment (by westonruter):

 @mrahmadawais that does look better, but I notice that the border on
 top/bottom is causing the border on the left to be cut diagonally. Perhaps
 a box shadow would have a better result?

 Also sorry but I uploaded a new patch [attachment:34893.7.diff]  that
 didn't include your change. I moved the `error` class to be an `data-`
 attribute of the list item itself. This meant that I needed to change the
 list styles to be compact when multiple are displayed. See [attachment
 :data-attributes.png].

 @celloexpressions thoughts on this change? I leave the CSS up to you :)

 Also, it would be easier to collaborate if you guys could push commits to
 the existing PR: https://github.com/xwp/wordpress-develop/pull/136 And
 this would avoid us having to manually reconcile and merge patches. You
 both have write access to that repo now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34893#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list