[wp-trac] [WordPress Trac] #34391: Harden panel/section UI code by removing contents from being logically nested (read: goodbye margin-top hacks)

[WordPress Trac]

#34391: Harden panel/section UI code by removing contents from being logically
nested (read: goodbye margin-top hacks)
------------------------------+--------------------------------------------
 Reporter:  westonruter       |       Owner:  delawski
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.6
Component:  Customize         |     Version:  4.0
 Severity:  normal            |  Resolution:
 Keywords:  4.6-early needs-  |     Focuses:  ui, accessibility, javascript
  patch                       |
------------------------------+--------------------------------------------
Changes (by celloexpressions):

 * keywords:  4.6-early has-patch => 4.6-early needs-patch


Comment:

 This is looking great so far! One notable change in terms of usability is
 that animations will be able to run much more smoothly when opening and
 closing panels.

 Testing with [attachment:34391_1.diff], it is not possible to open nav
 menu sections. The JS error thrown is related to initializing the sortable
 behavior here; I'm guessing that deferring that until the panel is fully
 expanded for the first time may help.

 Additionally, the custom "add menu" section, which is displayed inline, no
 longer works. If at all possible I would like to use this as an example of
 a custom section that shouldn't require modifications as a result of this
 ticket, since it completely overrides the core section behavior. If it
 does require changes, I think we should plan to commit this within the
 first week of the 4.7 cycle (ie, have a patch fully tested and ready to go
 before the end of 4.6) so that there is adequate notice to anyone who may
 be doing similar things. I think we can probably avoid this, however.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34391#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform