[wp-trac] [WordPress Trac] #35911: Simplify the credits page with an if/else statment

WordPress Trac noreply at wordpress.org
Sat May 14 20:11:18 UTC 2016


#35911: Simplify the credits page with an if/else statment
----------------------------+-----------------------------
 Reporter:  ramiy           |       Owner:  ocean90
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  4.6
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:                  |     Focuses:  administration
----------------------------+-----------------------------

Comment (by ramiy):

 @ocean90 please review the patch again.

 Currently we call the `admin-footer.php` twice, and use the `exit`
 function. It's redundant.

 ----

 The current code:
 {{{
 if ( ! $credits ) {
         ...
         ...
         include( ABSPATH . 'wp-admin/admin-footer.php' );
         exit;
 }

 ...
 ...

 include( ABSPATH . 'wp-admin/admin-footer.php' );
 }}}

 The new code:
 {{{
 if ( ! $credits ) {
         ...
         ...
 } else {
         ...
         ...
 }

 include( ABSPATH . 'wp-admin/admin-footer.php' );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35911#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list