[wp-trac] [WordPress Trac] #36832: Refactor for class-walker-nav-menu-edit.php

[WordPress Trac]

#36832: Refactor for class-walker-nav-menu-edit.php
-------------------------+------------------------------
 Reporter:  iamntz       |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Menus        |     Version:  trunk
 Severity:  normal       |  Resolution:  invalid
 Keywords:  has-patch    |     Focuses:  administration
-------------------------+------------------------------
Changes (by iamntz):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Replying to [comment:2 tw2113]:
 > I could see potential issue here, though not guaranteed, for anyone
 who's extended those classes. Especially if breaking things up into
 smaller methods for multiple parts instead of all being part of one/small
 handful of methods.

 Hmmm, you're right. I didn't take in account that case. I'll adjust the
 patch to not add the default hooks on __construct, but a bit later, inside
 of start_el method.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36832#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform