[wp-trac] [WordPress Trac] #36749: Customizer wont load: issue with site-icon control

[WordPress Trac]

#36749: Customizer wont load: issue with site-icon control
---------------------------------------+-------------------------
 Reporter:  raxcido                    |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  4.5.3
Component:  Customize                  |     Version:  4.5
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |     Focuses:  javascript
---------------------------------------+-------------------------

Comment (by Fabio A):

 Replying to [comment:4 swissspidy]:
 > Proposed fix 2 from #36820:
 >
 > {{{
 > <# data.attachment.sizes = data.attachment.sizes || { 'full': { 'url':
 data.attachment.url } } #>
 > <# if ( data.attachment && data.attachment.id ) { #>
 > }}}

 Shouldn't that rather be

 {{{
 <# if ( data.attachment && data.attachment.id ) { #>
 <# data.attachment.sizes = data.attachment.sizes || { 'full': { 'url':
 data.attachment.url } } #>
 }}}

 Or else, the code is bound to fail again if there's no attachment (and
 hence no {{{data.attachment}}} property), isn't it?

 > What would cause an image to not have a sizes property?

 The favicon causing the issue was an old one, could it be that in the
 previous releases favicons were handled differently than they are now? As
 I said in #36820, reuploading the favicon automatically generated the
 requested data that was missing.

 Alternatively, could this be a case of the database gone havoc due to some
 other bugs?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36749#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform