[wp-trac] [WordPress Trac] #33735: Reduce Duplication and Improve Comment Notification Email Functions

[WordPress Trac]

#33735: Reduce Duplication and Improve Comment Notification Email Functions
-------------------------------------------------+-------------------------
 Reporter:  dshanske                             |       Owner:
     Type:  enhancement                          |  SergeyBiryukov
 Priority:  low                                  |      Status:  reviewing
Component:  Comments                             |   Milestone:  Future
 Severity:  normal                               |  Release
 Keywords:  has-patch needs-refresh needs-unit-  |     Version:
  tests                                          |  Resolution:
                                                 |     Focuses:
-------------------------------------------------+-------------------------
Changes (by rachelbaker):

 * keywords:  good-first-bug has-patch needs-refresh => has-patch needs-
     refresh needs-unit-tests


Comment:

 @dshanske In your latest [attachment:33735.4.2.diff] you went back to
 using `$comment_id`  as the parameter for `get_comment_notify_text()`
 instead of passing in `$comment`.  Right now you are doing additional un-
 needed look-ups.  This would also benefit from unit tests to make sure
 your patch works as intended.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33735#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform