[wp-trac] [WordPress Trac] #31909: wp_dropdown_categories() select field cannot accept HTML 'required'

WordPress Trac noreply at wordpress.org
Thu May 5 17:11:00 UTC 2016


#31909: wp_dropdown_categories() select field cannot accept HTML 'required'
----------------------------------------+-----------------------
 Reporter:  wzislam                     |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  4.6
Component:  Taxonomy                    |     Version:  4.1.1
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  template
----------------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  has-patch dev-feedback => needs-patch good-first-bug
 * milestone:  Awaiting Review => 4.6


Comment:

 In a Slack discussion (see logs linked above), @helen and I decided that
 this ticket is probably not the appropriate place to open the can of worms
 that is the-way-that-WP-generates-form-markup. A generic 'atts' parameter
 is too big a hammer for the nail in this ticket. If someone feels strongly
 that an 'atts' approach should be adopted widely in WP, please open a
 separate ticket with a proposal.

 For the time being, let's go with a new `required` parameter, along the
 lines of [attachment:required-wp_dropdown_categories.31909.diff]. That
 patch should be updated with the following:

 - `@since` documentation in the docblock
 - There is no real reason for us to officially support integer values.
 Let's just call it `bool`.
 - A unit test showing that it works

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31909#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list