[wp-trac] [WordPress Trac] #36674: Make WP->parse_request() variables more self-descriptive

WordPress Trac noreply at wordpress.org
Tue May 3 19:35:23 UTC 2016


#36674: Make WP->parse_request() variables more self-descriptive
---------------------------+------------------------
 Reporter:  ericlewis      |       Owner:  ericlewis
     Type:  enhancement    |      Status:  closed
 Priority:  normal         |   Milestone:  4.6
Component:  Rewrite Rules  |     Version:
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------
Changes (by ericlewis):

 * owner:   => ericlewis
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"37356"]:
 {{{
 #!CommitTicketReference repository="" revision="37356"
 Rewrite Rules: Add self-describing variables to rewrite matcher.

 The rewrite rule matching code in WP::parse_request() used an unclear
 variable `$request` to represent the requested path (e.g. "2016/05/03") as
 well as a deceptively named variable `$request_uri`, which actually
 represents the requested file when an install used PATHINFO links.

 Those variables are replaced with `$requested_path` and `$requested_file`
 respectively for clarity.

 Fixes #36674.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36674#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list