[wp-trac] [WordPress Trac] #36208: Comment queries should ignore comments associated with non-active custom post types

[WordPress Trac]

#36208: Comment queries should ignore comments associated with non-active custom
post types
------------------------------------------+-----------------------------
 Reporter:  Clorith                       |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  Future Release
Component:  Comments                      |     Version:  4.4
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+-----------------------------

Comment (by Clorith):

 What if we explicitly look for the `any` keyword to trigger the addition
 of 36208.diff, and keep the `empty` check as it currently is with just a
 simple `continue` (so essentially spit up the `if or` into separate `if`
 statements on line 786).

 That would avoid us breaking any existing queries that use the
 `comment_post_ID` as `0`, yet give the enhancements we'd like, or am I
 missing something deeper perhaps?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36208#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform