[wp-trac] [WordPress Trac] #35878: In `wp.media.view.Attachment.render` tested parameter is missing a default.

WordPress Trac noreply at wordpress.org
Fri Mar 25 05:38:32 UTC 2016

#35878: In `wp.media.view.Attachment.render` tested parameter is missing a default.
 Reporter:  georgestephanis        |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  lowest                 |   Milestone:  Awaiting Review
Component:  Media                  |     Version:  4.2
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  javascript

Comment (by georgestephanis):

 @adamsilverstein It's PHPStorm --


 I guess at the least, I'd like to see the conditional changed to something
 like `if ( 'undefined' !== typeof options.nonces ) {` to make it explicit
 we're testing for something that may be unset?

 Maybe it's just my PHP brain throwing up danger signals about testing
 undefined indices.

Ticket URL: <https://core.trac.wordpress.org/ticket/35878#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list