[wp-trac] [WordPress Trac] #35855: Let selective refresh component be required but be opt-in for sidebars/widgets (for now)

WordPress Trac noreply at wordpress.org
Wed Mar 23 06:19:38 UTC 2016


#35855: Let selective refresh component be required but be opt-in for
sidebars/widgets (for now)
-------------------------------------+--------------------------
 Reporter:  DrewAPicture             |       Owner:  westonruter
     Type:  task (blessed)           |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.5
Component:  Customize                |     Version:  trunk
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------
Changes (by westonruter):

 * status:  closed => reopened
 * resolution:  fixed =>


Old description:

> Instead of adding a method to determine whether Selective Refresh
> (#27355) is active, it can instead be always active but specific
> components can opt-in for support as required: specifically widgets.
>
> Currently `isset( $this->manager->selective_refresh )` is used to choose
> between the 'postMessage' and 'refresh' transports in a bunch of
> different places.
>
> Instead, there can be specific theme support and widget opt-in for
> selective refresh. See code in the original Widget Customizer plugin for
> reference: https://github.com/xwp/wp-widget-customizer/compare/without-
> partial-previews

New description:

 Instead of adding a method to determine whether Selective Refresh (#27355)
 is active, it can instead be always active but specific components can
 opt-in for support as required: specifically widgets.

 Currently `isset( $this->manager->selective_refresh )` is used to choose
 between the 'postMessage' and 'refresh' transports in a bunch of different
 places.

 Instead, there can be specific theme support and widget opt-in for
 selective refresh. See code in the original Widget Customizer plugin for
 reference: https://github.com/xwp/wp-widget-customizer/compare/without-
 partial-previews

 ----

 For details, see Make Core post:
 [https://make.wordpress.org/core/2016/03/22/implementing-selective-
 refresh-support-for-widgets/ Implementing Selective Refresh Support for
 Widgets]

--

Comment:

 [37040] failed to update the terminology from site logo to custom logo,
 resulting in the preview no longer working as noted in
 https://core.trac.wordpress.org/ticket/36255#comment:37

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35855#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list