[wp-trac] [WordPress Trac] #34870: dbDelta Not Specifying Key Length Duplicate Indexes

[WordPress Trac]

#34870: dbDelta Not Specifying Key Length Duplicate Indexes
-------------------------------------------------+-------------------------
 Reporter:  charlestonsw                         |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Database                             |  Review
 Severity:  normal                               |     Version:  2.8.1
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests dev-feedback                             |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------
Changes (by mikejolley):

 * keywords:   => has-patch needs-testing needs-unit-tests dev-feedback


Comment:

 So I've done some work on this
 (https://core.trac.wordpress.org/attachment/ticket/34870/fix.34870.diff)
 and have made it so if it detects an existing index with the same name,
 the previous index is dropped first.

 This is all fine and dandy, but I have one concern. Table locking.

 Dropping and adding indexes can be **really** slow on large tables and
 older versions of MySQL, but I'm not sure we can do anything about it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34870#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform