[wp-trac] [WordPress Trac] #33755: Add Custom Logo to WordPress Core

WordPress Trac noreply at wordpress.org
Mon Mar 14 19:16:15 UTC 2016

#33755: Add Custom Logo to WordPress Core
 Reporter:  fatmedia                             |       Owner:  obenland
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  ux-feedback needs-unit-tests has-    |     Focuses:  ui
  screenshots needs-patch                        |

Comment (by westonruter):

 In [changeset:"36990"]:
 #!CommitTicketReference repository="" revision="36990"
 Customize: Rely on selective refresh exclusively for previewing custom
 logo changes.

 Eliminates JS logic (from [36698]) which attempted to do pure JS update
 while waiting for the selective refresh response to return. The duplicate
 JS logic lacked a re-implementation of the `image_downsize()`
 functionality available in PHP, and so the JS preview logic would fail to
 properly preview images that didn't have the exact theme image size
 generated. To keep the code DRY and to eliminate the momentary display of
 an improperly-sized image, the duplicated JS logic is now removed.

 See #27355.
 See #33755.
 Fixes #36096.

Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:149>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list