[wp-trac] [WordPress Trac] #36171: Proposed clean up of get_the_category_list() and link filter

WordPress Trac noreply at wordpress.org
Mon Mar 14 02:27:04 UTC 2016


#36171: Proposed clean up of get_the_category_list() and link filter
--------------------------------------------+-----------------------------
 Reporter:  pietergoosen                    |       Owner:
     Type:  enhancement                     |      Status:  new
 Priority:  normal                          |   Milestone:  Future Release
Component:  Taxonomy                        |     Version:  4.4.2
 Severity:  normal                          |  Resolution:
 Keywords:  needs-testing needs-unit-tests  |     Focuses:  template
--------------------------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  needs-testing => needs-testing needs-unit-tests
 * focuses:  performance => template
 * component:  Formatting => Taxonomy
 * milestone:  Awaiting Review => Future Release


Comment:

 Hi @pietergoosen - Thanks very much for the suggested improvements.

 The changes generally look good. The DRY cleanup looks fine at a glance,
 and the additional filter will be quite welcome.

 I've reformatted your suggestions as a proper patch. See
 https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
 for more info on how patches are generated. [attachment:36171.diff]

 Unfortunately, `get_the_category_list()` currently has zero coverage by
 automated tests. Fairly decent tests are critical before we can consider
 this kind of refactor.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36171#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list