[wp-trac] [WordPress Trac] #35922: get_edit_term_link should not require $taxonomy

WordPress Trac noreply at wordpress.org
Sun Mar 13 14:31:21 UTC 2016


#35922: get_edit_term_link should not require $taxonomy
-------------------------+---------------------------
 Reporter:  nicdford     |       Owner:  boonebgorges
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  4.5
Component:  Taxonomy     |     Version:  4.4
 Severity:  normal       |  Resolution:  fixed
 Keywords:               |     Focuses:
-------------------------+---------------------------

Comment (by swissspidy):

 @boonebgorges While working on #36224 I noticed that
 `test_cap_check_should_use_correct_taxonomy_when_taxonomy_is_not_specified`
 is not 100% correct / incomplete.

 First, `manage_terms` is not a direct taxonomy property, but can only be
 passed as part of the `capabilities` array.
 Second, `get_edit_term_link()` checks against `edit_terms` capability, not
 `manage_terms`.
 Third, the `wptests_tax_subscriber` taxonomy isn't even used in the test.

 I'd add a new test to check that the custom capabilities get respected
 when using `get_edit_term_link()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35922#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list