[wp-trac] [WordPress Trac] #35993: Unit tests: XML-RPC Request routines

WordPress Trac noreply at wordpress.org
Thu Mar 10 14:05:03 UTC 2016


#35993: Unit tests: XML-RPC Request routines
-------------------------------------------------+-------------------------
 Reporter:  borgesbruno                          |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  XML-RPC                              |  Release
 Severity:  normal                               |     Version:
 Keywords:  has-patch has-unit-tests dev-        |  Resolution:
  feedback                                       |     Focuses:
-------------------------------------------------+-------------------------

Comment (by markoheijnen):

 I just looked over it and the main thing I wonder is why the usage of
 global?

 The value of `_xml_rpc_request_fixture()`need to change to just be
 everything inside the <param>. It grabs the content from param 4 for both
 function calls.

 Also I think it would be best to have content also be included in
 `_xml_rpc_request_fixture()` to get the real value of it.
 Then in `test_xmlrpc_removepostdata()` we can just compare
 `xml_rpc_without_post_data ` with `xml_rpc_request_fixture()`,

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35993#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list